Draft
Conversation
2bndy5
added
enhancement
2bndy5
force-pushed
the
clang-tools-downloader
branch
7 times, most recently
from
ff341e6 to
4e603b1
Compare
In order of precedence, this patch allows installing clang tools from 1. PyPI (downloaded wheels are verified using SHA256 or Bake2b256) 2. system package manager(s) (if available) 3. static binaries (verified with accompanied SHA512 checksum) Also upgrade cargo/rust dependencies.
disables any API that is specific to building a binary. Thus CLI-specific API is not exposed in the library API. Also reviewed docs
2bndy5
force-pushed
the
clang-tools-downloader
branch
3 times, most recently
from
5719c93 to
9662089
Compare
also check cache before (re)populating it
2bndy5
force-pushed
the
clang-tools-downloader
branch
from
9662089 to
6fc06b6
Compare
2bndy5
force-pushed
the
clang-tools-downloader
branch
from
89de56d to
f005df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order of precedence, this patch allows installing clang tools from
pipare not required.The executable binary is extracted from the downloaded wheel.
MIN_CLANG_TOOLS_VERSIONandMAX_CLANG_TOOLS_VERSIONrespectively.CLANG_TOOLS_TAGat compile time (not runtime).CLANG_TOOLS_REPOat compile time (not runtime).Caching
Caching is enabled per OS standards and specific to cpp-linter use.
Caching does not apply to package managers as they tend to manage caches on their own.
Cache directory can be overridden using the
CPP_LINTER_CACHEenvironment variable.Also upgrade cargo/rust dependencies.