Skip to content

Fix #139: From-scratch clone/build fails on src/ftxui_sample/CMakeFiles/intro.dir/main.cpp.obj #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leftibot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #139: From-scratch clone/build fails on src/ftxui_sample/CMakeFiles/intro.dir/main.cpp.obj #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"strategy": "external"
},
"cacheVariables": {
"ENABLE_CPPCHECK_DEFAULT": "FALSE",
"ENABLE_CLANG_TIDY_DEFAULT": "FALSE"
"myproject_ENABLE_CPPCHECK": "FALSE",
"myproject_ENABLE_CLANG_TIDY": "FALSE"
}
},
{
Expand Down
9 changes: 9 additions & 0 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ endif()

include(${Catch2_SOURCE_DIR}/extras/Catch.cmake)

# Regression test for issue #139: ensure windows-clang preset actually disables
# cppcheck/clang-tidy by setting the real project option names.
add_test(
NAME presets.windows_disables_static_analysis
COMMAND
${CMAKE_COMMAND}
-DPRESETS_FILE=${CMAKE_SOURCE_DIR}/CMakePresets.json
-P ${CMAKE_CURRENT_SOURCE_DIR}/test_cmake_presets.cmake)

# Provide a simple smoke test to make sure that the CLI works and can display a --help message
add_test(NAME cli.has_help COMMAND intro --help)

Expand Down
49 changes: 49 additions & 0 deletions test/test_cmake_presets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Regression test for issue #139.
#
# CMakePresets.json must disable cppcheck and clang-tidy on the windows-clang
# preset using the project's actual option names, otherwise from-scratch builds
# fail when WARNINGS_AS_ERRORS is on and cppcheck flags third-party headers.

if(NOT DEFINED PRESETS_FILE)
message(FATAL_ERROR "PRESETS_FILE not defined")
endif()

file(READ "${PRESETS_FILE}" PRESETS_JSON)

string(JSON CONFIGURE_PRESETS_LEN LENGTH "${PRESETS_JSON}" "configurePresets")
math(EXPR LAST_PRESET_IDX "${CONFIGURE_PRESETS_LEN} - 1")

set(WINDOWS_PRESET_INDEX -1)
foreach(I RANGE 0 ${LAST_PRESET_IDX})
string(JSON NAME GET "${PRESETS_JSON}" "configurePresets" ${I} "name")
if(NAME STREQUAL "conf-windows-common")
set(WINDOWS_PRESET_INDEX ${I})
break()
endif()
endforeach()

if(WINDOWS_PRESET_INDEX EQUAL -1)
message(FATAL_ERROR "conf-windows-common preset not found in ${PRESETS_FILE}")
endif()

string(JSON CACHE_VARS GET "${PRESETS_JSON}"
"configurePresets" ${WINDOWS_PRESET_INDEX} "cacheVariables")

function(_assert_disabled var_name)
string(JSON VAL ERROR_VARIABLE ERR GET "${CACHE_VARS}" "${var_name}")
if(ERR)
message(FATAL_ERROR
"conf-windows-common cacheVariables is missing ${var_name}; "
"expected it to disable the analyzer (issue #139). "
"JSON error: ${ERR}")
endif()
if(NOT (VAL STREQUAL "OFF" OR VAL STREQUAL "FALSE" OR VAL STREQUAL "0" OR VAL STREQUAL "NO"))
message(FATAL_ERROR
"conf-windows-common cacheVariables sets ${var_name}=${VAL}, expected OFF/FALSE")
endif()
endfunction()

_assert_disabled("myproject_ENABLE_CPPCHECK")
_assert_disabled("myproject_ENABLE_CLANG_TIDY")

message(STATUS "conf-windows-common correctly disables cppcheck and clang-tidy")
Loading