[template.bitset.general][vector.bool.pspc] Make subclauses for reference nested classes#8661
Open
AlisdairM wants to merge 2 commits intocplusplus:mainfrom
Open
[template.bitset.general][vector.bool.pspc] Make subclauses for reference nested classes#8661AlisdairM wants to merge 2 commits intocplusplus:mainfrom
reference nested classes#8661AlisdairM wants to merge 2 commits intocplusplus:mainfrom
Conversation
Member
|
Can you make this two commits please (keep them in this single pull request)? |
AlisdairM
force-pushed
the
create_subclause_for_reference_types
branch
4 times, most recently
from
2f838c5 to
afa9ade
Compare
Contributor
Author
|
Split into two commits, making the requested change to separate out the template-head in each case. |
jensmaurer
requested changes
Dec 22, 2025
AlisdairM
force-pushed
the
create_subclause_for_reference_types
branch
from
afa9ade to
a138504
Compare
jensmaurer
approved these changes
Dec 22, 2025
Member
|
The commit descriptions (in particular the titles) aren't stellar. "Break out into its own subclause" is missing "reference" and/or "nested class" somewhere. In particular since the new label is [vector.bool.reference], not the quoted label. |
Contributor
Author
|
It looks like my git command line mangled my attempts to put the class names into the commit title line. I will fix just those commit messages and resubmit. |
…subclause This change is consistent with specification of nested classes elsewhere in the standard, and allows better use of qualified names in the declaration of member functions in their own specification.
…ubclause This change is consistent with specification of nested classes elsewhere in the standard, and allows better use of qualified names in the declaration of member functions in their own specification.
AlisdairM
force-pushed
the
create_subclause_for_reference_types
branch
from
a138504 to
c9a4561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistent with other nested classes within the standard library. This formulation leads to slightly clearer specification for the member functions that now use appropriately qualified names.