[basic] Use past subjunctive after "as if"#8656
Open
lprv wants to merge 1 commit intocplusplus:mainfrom
Open
Conversation
jensmaurer
approved these changes
Dec 16, 2025
Contributor
|
@W-E-Brown for commentary perhaps? |
Contributor
|
I don't think the status quo is wrong; it's just a stylistic choice. We could change it, but... we could change a lot of things. |
Contributor
|
On Dec 16, 2025, at 5:22 AM, Thomas Köppe ***@***.***> wrote:
tkoeppe
left a comment
(cplusplus/draft#8656)
<#8656 (comment)>
@W-E-Brown <https://github.com/W-E-Brown> for commentary perhaps?
Well, since you asked ... :)
Grammatically, the change to the subjunctive following the conditional "if" seems correct to me. However, I found [class.compare.default]/Note 2 where a similar change could (and likely should) be made. It wouldn't surprise me to find more such places.
More generally, the intent of (the multiple occurrences) of the phrase "it is as if" is not clear to me, since I don't know (and can't seem to find) the antecedent of "it" in these contexts. I'm sure this is not what we wanted to hear at this late stage, but (unless I'm overlooking something obvious to others) this strikes me as a substantial defect needing clarification in the current wording.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.