[refactor][backend] support configurable force_path_style for S3 client#429
Open
userwanyong wants to merge 1 commit intocoze-dev:mainfrom
Open
[refactor][backend] support configurable force_path_style for S3 client#429userwanyong wants to merge 1 commit intocoze-dev:mainfrom
userwanyong wants to merge 1 commit intocoze-dev:mainfrom
Conversation
Previously, the ForcePathStyle setting was hardcoded based on domain name detection, making it difficult to adapt to different object storage services. This commit refactors the getOssForcePathStyle function to read from the configuration file (infrastructure.yaml) with a fallback to domain-based detection for backward compatibility. Changes: - Modify getOssForcePathStyle to accept componentConfig parameter - Prioritize reading force_path_style from s3_config in infrastructure.yaml - Fallback to domain-based detection when config is not set Benefits: - Flexibility to configure force_path_style for any S3-compatible storage - Easier integration with different object storage backends (MinIO, RustFS, etc.) - Maintains backward compatibility with existing deployments
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the ForcePathStyle setting was hardcoded based on domain name detection, making it difficult to adapt to different object storage services.
This commit refactors the getOssForcePathStyle function to read from the configuration file (infrastructure.yaml) with a fallback to domain-based detection for backward compatibility.
Changes:
Benefits:
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes