Skip to content

Conversation

@jmg-duarte
Copy link
Contributor

@jmg-duarte jmg-duarte commented Jan 22, 2026

Description

#4070 introduced some flakyness to the e2e test suite, this PR should fix that

Changes

  • Re-organized the test order to make more sense when reading
  • Changed the wait_for_condition to wait for a trade that has a tx_hash
  • Mint blocks with the settlement wait condition

How to test

https://github.com/cowprotocol/services/actions/runs/21246964171/job/61138541511?pr=4079

 RUST_BACKTRACE=1 cargo nextest run -r -p e2e local_node_solver_competition_v1 --test-threads 1 --failure-output final --run-ignored ignored-only

@jmg-duarte jmg-duarte marked this pull request as ready for review January 22, 2026 12:52
@jmg-duarte jmg-duarte requested a review from a team as a code owner January 22, 2026 12:52
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses flakiness in e2e tests by refining the wait conditions and block minting strategy. The re-organization of test order also contributes to better readability. However, there are a couple of areas where the assumptions in the test code could be made more robust to prevent potential panics or unexpected behavior.

@jmg-duarte jmg-duarte enabled auto-merge January 22, 2026 14:03
@jmg-duarte jmg-duarte added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit a0946bf Jan 22, 2026
19 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/e2e/flaky branch January 22, 2026 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants