Migrate alerter crate from warp to axum #4045
Conversation
Replace warp with axum for the alerter service's metrics endpoint. Add axum metrics handler to observe crate, gated behind the existing axum-tracing feature to maintain backward compatibility. Changes: - Add handle_metrics_axum() to observe crate (feature-gated) - Update alerter to use axum::Server::bind() API - Enable axum-tracing feature in alerter's observe dependency - Fix observe Cargo.toml to use dep:axum syntax for feature - Replace warp dependency with axum in alerter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the alerter crate from warp to axum, modernizing the service and correctly implementing the axum server for metrics. However, a potential Denial of Service vulnerability was identified due to an unhandled error when starting the server. Improving error handling is recommended to prevent silent failures and ensure better observability.
| pub fn handle_metrics_axum() -> axum::Router { | ||
| async fn metrics_handler() -> String { | ||
| encode(get_registry()) | ||
| } | ||
|
|
||
| axum::Router::new().route("/metrics", axum::routing::get(metrics_handler)) | ||
| } |
There was a problem hiding this comment.
This function is not as composable as the warp one as it already creates the whole router and not just the /metrics handler. I think this would have to be adjusted if you want to use it for example in the orderbook crate which has more than the metrics endpoint.
There was a problem hiding this comment.
For metrics specifically, it doesn't matter much because the metrics endpoint is a whole separate service — see serve_metrics
I'll migrate the metrics endpoint after to make this uniform
Description
Migrate the alerter crate from warp to axum (part of Q1 roadmap)
Changes
handle_metrics_axum()function to observe crate (feature-gated)dep:axumsyntaxHow to test
cargo r -p alerter --bin alerter -- --zero-ex-api-key ""curl -X GET http://localhost:9588/metrics