Vendor gas-estimation crate into shared module #4043

jmg-duarte · 2026-01-12T16:32:31Z

Description

Remove the external gas-estimation dependency by vendoring necessary functionality into the shared/gas_price_estimation module. This simplifies gas estimation by removing the Native estimator and its complex percentile-based calculations.

Changes

Vendor GasPrice1559, GasPriceEstimating, and PriorityGasPriceEstimating into shared/gas_price_estimation
Add NodeGasPriceEstimator to replace web3.legacy usage
Remove gas-estimation dependency from all crate manifests
Remove Native gas estimator configuration option
Update all imports from gas_estimation:: to shared::gas_price_estimation::
Simplify GasPriceEstimating trait (remove estimate_with_limits method)
Adjust driver tests to handle gas price variations (15% tolerance)

How to test

Existing tests

Removed external gas-estimation dependency by vendoring its code into shared/gas_price_estimation module: - Inlined GasPriceEstimating and PriorityGasPriceEstimating traits - Vendored GasPrice1559 type into price module - Created NodeGasPriceEstimator to replace web3 legacy gas estimation - Removed NativeGasEstimator and Native gas estimator config option - Updated driver and refunder crates to use vendored implementations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

jmg-duarte · 2026-01-12T16:32:42Z

/gemini review

gemini-code-assist

Code Review

This pull request is a significant step in migrating away from ethcontract by vendoring the gas-estimation crate's functionality directly into the shared crate. The changes are well-structured, removing the old dependency and updating all usage sites to the new vendored implementation. The removal of NativeGasEstimator and its replacement with NodeGasPriceEstimator and making Alloy the default is a notable change that simplifies the configuration. Overall, the refactoring is clean and aligns with the goal of moving towards Alloy APIs. I've found two issues that need to be addressed: a critical syntax error that prevents compilation and an outdated error message.

crates/shared/src/gas_price_estimation/mod.rs

gemini-code-assist

Code Review

This pull request is a large but well-executed refactoring to vendor the gas-estimation crate into the shared module, successfully removing an external dependency. The core logic has been cleanly moved, and the GasPriceEstimating trait has been simplified. My review focuses on a new test helper function where I've found a critical compilation error and a potential panic, along with a minor suggestion to improve test diagnostics. The rest of the changes look solid.

crates/driver/src/tests/setup/solver.rs

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

MartinquaXD · 2026-01-15T08:59:37Z

crates/driver/src/tests/setup/solver.rs

                &[infra::mempool::Config {
                    min_priority_fee: Default::default(),
-                    gas_price_cap: eth::U256::MAX,
+                    gas_price_cap: eth::U256::from(1000000000000_u128),


We added this ad-hoc to make sure the mempool parameters that affect the gas price estimator config are in sync with the driver under test and the gas estimator struct the test logic compares against but is there a better way to make sure these are in sync rather than hardcoding magic numbers here?

I have an idea but it's orthogonal to the current PR.

IMO, in crates/driver/src/tests/setup/driver.rs we shouldn't be writing the config TOML manually, we should pass a config and serialize it into a file. Makes it easier to navigate to with the editors and to inspect as well

crates/driver/src/tests/setup/solver.rs

crates/shared/src/gas_price_estimation/eth_node.rs

crates/shared/src/gas_price_estimation/mod.rs

crates/shared/src/gas_price_estimation/price.rs

MartinquaXD · 2026-01-15T09:15:12Z

crates/shared/src/gas_price_estimation/price.rs

+    // Estimated base fee for the pending block (block currently being mined)
+    pub base_fee_per_gas: f64,


I remember we discussed dropping this field. Is this no longer the plan or intended as a follow up item?

Follow up, the gas-2 branch does it. I wanted to keep this branch mostly similar to the original crate to simplify the review

crates/driver/src/tests/cases/mod.rs

squadgazzz

LGTM, assuming the comments below will be addressed.

crates/shared/src/gas_price_estimation/eth_node.rs

crates/shared/src/gas_price_estimation/priority.rs

crates/shared/src/gas_price_estimation/eth_node.rs

squadgazzz · 2026-01-16T11:08:17Z

crates/shared/src/gas_price_estimation/alloy.rs

 };

-pub struct AlloyGasPriceEstimator(AlloyProvider);
+/// Estimates the gas price based on alloy's logic for computing a reasonable EIP-1559 gas price.


I mean, it would be great to understand already from these docs how the Node estimation is different from EIP-1559. Maybe mentioning major mechanics would be sufficient here.

Addressed, please review

jmg-duarte and others added 2 commits January 12, 2026 15:16

Migrate shared off of ethcontract

2b6bf23

gemini-code-assist bot reviewed Jan 12, 2026

View reviewed changes

crates/shared/src/gas_price_estimation/mod.rs Outdated Show resolved Hide resolved

jmg-duarte changed the title ~~Migrate shared off of ethcontract~~ Vendor gas-estimation crate into shared module Jan 12, 2026

remove unused fn from trait

5e7e7a2

Base automatically changed from jmgd/alloy/shared to main January 13, 2026 16:30

jmg-duarte added 5 commits January 13, 2026 16:43

Merge branch 'main' into jmgd/alloy/gas

fa90a4c

address gemini comment

ea800d9

compilation error

1e2e165

Address river error

a6a467c

address clippy

5065765

jmg-duarte marked this pull request as ready for review January 14, 2026 17:37

jmg-duarte requested a review from a team as a code owner January 14, 2026 17:37

gemini-code-assist bot reviewed Jan 14, 2026

View reviewed changes

crates/driver/src/tests/setup/solver.rs Outdated Show resolved Hide resolved

crates/driver/src/tests/setup/solver.rs Outdated Show resolved Hide resolved

crates/driver/src/tests/setup/solver.rs Outdated Show resolved Hide resolved

Update crates/driver/src/tests/setup/solver.rs

05c2c01

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

MartinquaXD reviewed Jan 15, 2026

View reviewed changes

jmg-duarte added 2 commits January 15, 2026 11:23

address comments

aa62ec2

alleviate issue with the magic numbers

3dd9f64

jmg-duarte requested a review from MartinquaXD January 15, 2026 11:33

MartinquaXD reviewed Jan 15, 2026

View reviewed changes

crates/driver/src/tests/cases/mod.rs Outdated Show resolved Hide resolved

jmg-duarte added 3 commits January 15, 2026 15:38

is_approx_eq

a507ca9

approx_eq improvements

ec38cd7

clippy

876fd43

MartinquaXD approved these changes Jan 15, 2026

View reviewed changes

crates/driver/src/tests/cases/mod.rs Outdated Show resolved Hide resolved

crates/driver/src/tests/cases/mod.rs Show resolved Hide resolved

squadgazzz approved these changes Jan 15, 2026

View reviewed changes

crates/shared/src/gas_price_estimation/eth_node.rs Show resolved Hide resolved

crates/shared/src/gas_price_estimation/priority.rs Outdated Show resolved Hide resolved

crates/shared/src/gas_price_estimation/eth_node.rs Outdated Show resolved Hide resolved

jmg-duarte added 4 commits January 16, 2026 10:22

Add docs on estimation

e24261a

Fix error logging

e57ba60

Rename and document eip1559 gas estimator

7d5e35d

Add tests

72690d4

squadgazzz reviewed Jan 16, 2026

View reviewed changes

jmg-duarte added 2 commits January 16, 2026 11:33

fmt

a645df7

Address comments

309e33d

squadgazzz approved these changes Jan 16, 2026

View reviewed changes

jmg-duarte added this pull request to the merge queue Jan 16, 2026

Merged via the queue into main with commit 94fcfd8 Jan 16, 2026
19 checks passed

jmg-duarte deleted the jmgd/alloy/gas branch January 16, 2026 14:40

github-actions bot locked and limited conversation to collaborators Jan 16, 2026

		// Estimated base fee for the pending block (block currently being mined)
		pub base_fee_per_gas: f64,

Vendor gas-estimation crate into shared module #4043

Vendor gas-estimation crate into shared module #4043

Uh oh!

Conversation

jmg-duarte commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

How to test

Uh oh!

jmg-duarte commented Jan 12, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinquaXD Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

jmg-duarte Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinquaXD Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

jmg-duarte Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

squadgazzz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

squadgazzz Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

jmg-duarte Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmg-duarte commented Jan 12, 2026 •

edited

Loading

jmg-duarte Jan 15, 2026 •

edited

Loading