Skip to content

Update fees.md #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pretf00d wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Update fees.md #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/governance/fees/fees.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@ The purpose of this page is to let users know which fee models are active at any

### Surplus fee on out-of-market limit orders

> **Definition:** 50% of surplus on out-of-market limit orders, capped at 0.98% of the total volume of the order
> **Definition:** 50% of surplus on out-of-market limit orders, capped at 1% of the total volume of the order
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Surplus fee cap text and formula conflict (1% vs 0.98%).

Line 19 states a 1% cap, but the surplus fee formula in this block uses volume * 0.0098. Please align them to one cap value; otherwise users may compute different fees from the same section.

Proposed doc fix (if cap is truly 1%) 
-> **Fee calculation:** surplus \* 0.5 **OR** volume \* 0.0098 [whichever number is lower]
+> **Fee calculation:** surplus \* 0.5 **OR** volume \* 0.01 [whichever number is lower]
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/governance/fees/fees.md` at line 19, The doc currently says "capped at
1% of the total volume" under the Definition block but the formula uses `volume
* 0.0098`; update the formula to match the stated cap by replacing `volume *
0.0098` with `volume * 0.01` and ensure the surrounding text (the "Definition:"
line stating 50% of surplus ... capped at 1%) remains consistent with that
formula.

>
> **Eligible orders:** the fee only applies to out-of-market limit orders and discrete TWAP orders where the order is not executable at the time it is generated
>
> **Fee calculation:** surplus \* 0.5 **OR** volume \* 0.0098 [whichever number is lower]

### Quote improvement fee on market orders

> **Definition:** 50% of positive quote improvement on market orders (aka swaps), capped at 0.98% of the total volume of the order
> **Definition:** 50% of positive quote improvement on market orders (aka swaps), capped at 1% of the total volume of the order
>
> **Eligible orders:** all market orders (including in-market limit and TWAP orders) where the user receives a better price than they were quoted
>
> **Fee calculation:** quote improvement \* 0.5 **OR** volume \* 0.0098 [whichever number is lower]
> **Fee calculation:** quote improvement \* 0.5 **OR** volume \* 0.01 [whichever number is lower]

### Volume Fee

Expand Down
Loading