Restore Foundry isolated execution#29
Open
igorroncevic wants to merge 1 commit into
Open
Conversation
igorroncevic
force-pushed
the
feat/restore-foundry-isolate
branch
from
e4f6288 to
271efec
Compare
igorroncevic
force-pushed
the
feat/restore-foundry-isolate
branch
from
271efec to
4ccca16
Compare
igorroncevic
force-pushed
the
feat/restore-foundry-isolate
branch
from
4ccca16 to
822a7d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isolate = trueback tofoundry.toml.just coverage-checkto preserve snapshot diffs while coverage runs, matching the linked solver PR change.Context
This was the intended behavior initially, but the setting got lost while other PRs were merged and was mistakenly deleted.
With
isolate = true,coverage-checkcan generate different snapshots. Instead of committing generated snapshots in this template PR,coverage-checknow restores snapshot changes after coverage runs.Verification
just coverage-checkjust lint,just slither,just coverage-check