RCBC-543: Add consistency helper for update_collection tests#227
Open
DemetrisChr wants to merge 1 commit intocouchbase:mainfrom
Open
RCBC-543: Add consistency helper for update_collection tests#227DemetrisChr wants to merge 1 commit intocouchbase:mainfrom
DemetrisChr wants to merge 1 commit intocouchbase:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new consistency helper to reduce CI flakiness in update_collection tests by waiting until updated collection settings are visible across all cluster nodes.
Changes:
- Introduce
wait_until_collection_satisfies_predicatein the test consistency helper to wait on arbitrary collection-state predicates across nodes. - Use the new helper in
collection_manager_testafterupdate_collectioncalls (history retention and max expiry cases).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/utils/consistency_helper.rb | Adds a generic “wait until collection matches predicate” helper using the management /scopes endpoint across all management nodes. |
| test/collection_manager_test.rb | Updates update_collection tests to wait for cluster-wide propagation before asserting on collection settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e77b521 to
32f2361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collection settings update happens asynchronously across the cluster. This results in
update_collectionintermittently failing on CI. This change adds a consistency helper for ensuring that the settings have been updated across all nodes, similar to what we have for creating and dropping collections.