Fix: keep direction of nearby numbers when obfuscating with rtl-text #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
isolate-overrideinstead ofbidi-overrideto keep the direction of numbers next to the obfuscated text.Description
isolate-overrideinstead ofbidi-overridewhen it is set as value forunicode-bidi.Types of changes
Checklist:
I am not sure about this point. I did not find a description of the coding style
I am not sure if the chapter about the chrome-bug is still valid with this change applied.
I also found that the described way of setting
display: inline-blockcould solve the issue as well. Since my change would prevent the bug and also prevent applying this workaround it improves the API of the component IF there are no side-effects I didn't perceive.