Skip to content

Conversation

@jonaphil
Copy link

@jonaphil jonaphil commented Jan 8, 2026

Use isolate-override instead of bidi-override to keep the direction of numbers next to the obfuscated text.

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

I am not sure about this point. I did not find a description of the coding style

  • If my change requires a change to the documentation I have updated the documentation accordingly.

I am not sure if the chapter about the chrome-bug is still valid with this change applied.

I also found that the described way of setting display: inline-block could solve the issue as well. Since my change would prevent the bug and also prevent applying this workaround it improves the API of the component IF there are no side-effects I didn't perceive.

@vercel
Copy link

vercel bot commented Jan 8, 2026

@jonaphil is attempting to deploy a commit to the Coston's projects Team on Vercel.

A member of the Team first needs to authorize it.

@jonaphil jonaphil changed the title Fix: keep direction of nerby numbers when obfuscating with rtl-text Fix: keep direction of nearby numbers when obfuscating with rtl-text Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Numbers get reverted by bidi-override, although the are outside

1 participant