Skip to content

Conversation

@ckierans
Copy link
Collaborator

Julian reported that the slow threshold cut was dramatically decreasing the number of events in the final ARM plots (using cut of 35 keV).

I confirmed with HP52358-3 gse_20250709T113820.hdf that I recovered only 30% of Compton events in revan when the slow threshold of 35 keV was applied.

The changes implemented:

  • Updated the logic of the threshold loop so the other strip hits in the event are calibrated ("return false" meant the whole event was skipped if one SH was found to have below threshold energy)
  • Updated the error code so that a c_Warning is created for any SH below threshold, and the energy is included in the warning message
  • Updated the ReadAssembly so the events with a SH below threshold now get a "QA" flag instead of a "BD" flag so these events aren't filtered out in revan. (As part of the other issue to go through all BD flags in Nuclearizer (Check all BD flags! #50), some other flags will use this QA nomenclature)
  • ran clang-format on MModuleEnergyCalibrationUniversal so there are lots of formatting fixes

After these changes we now recover 71% of Compton events in revan with the 35 keV threshold (and 99.5% of the Compton events when using a slow threshold file with realistic thresholds ~10 keV). I confirmed the ARM isn't dramatically altered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant