-
Notifications
You must be signed in to change notification settings - Fork 12
Including Metrology Mask Rotation #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ckierans
wants to merge
23
commits into
cositools:develop/em
Choose a base branch
from
ckierans:metrology_fix
base: develop/em
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6d926ee
ADD: Including Mask Metrology file in Depth Calibration, correction s…
ckierans 1f2163f
CHG: Updated x,y definition with mask rotation, added print statements
ckierans 5577c2e
Updated metrology with correct understanding of rotation angles, now …
ckierans d05aa6a
Strip Pairing Chi Square Algorithm Updated (#61)
julianmgerber 6ba6e6b
Resolving merge conflict with Sean's recent PR
ckierans beb5c32
CHG: Updated x,y definition with mask rotation, added print statements
ckierans c138b17
Updated metrology with correct understanding of rotation angles, now …
ckierans 9410061
Strip Pairing Chi Square Algorithm Updated (#61)
julianmgerber f858369
Resolving merge conflict with Sean's recent PR
ckierans 108275f
Resolving merge conflict with Sean's recent PR
ckierans e0861b2
[DEE] Improve strip ID handling for guard ring events
fhagemann 7c3d1d6
Add TODOs
fhagemann 3d3e0e3
ADD: How to handle ToDo's
zoglauer 3eeacff
CHG: Updated README.md
zoglauer 5038c55
CHG: Add historic contributors
zoglauer 2fb1580
Resolving merge conflict with Sean's recent PR
ckierans 230f190
Cleanup: added comments and cleaned up extraneous print statements
snpike 649f74c
BUG: Clear variables on Finalize
snpike f5c13f0
[DEE] Read detector dimensions from the geometry (#76)
fhagemann 22f3214
Resolving merge conflict with Sean's recent PR
ckierans a5a5de2
CHG: Updated x,y definition with mask rotation, added print statements
ckierans 1d90cc8
Merge branch 'metrology' into metrology_merge
ckierans 92ed5b7
Removing a vim mistype
ckierans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need that?
The UCSD code should be its own branch and not be in the main code?
Maybe make an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue for this. Leaving this code for now.