Skip to content

Fix Chosen connection form tracking interference#609

Open
CSWinnall wants to merge 1 commit into
devfrom
fix/chosen-connection-form-tracking
Open

Fix Chosen connection form tracking interference#609
CSWinnall wants to merge 1 commit into
devfrom
fix/chosen-connection-form-tracking

Conversation

@CSWinnall
Copy link
Copy Markdown
Collaborator

Summary

  • skip KTL's generic form-content tracking for Chosen-backed connection fields
  • keep the existing dedicated .chzn-select dropdown change path for persistent-form updates
  • add a backstop guard inside formContentHasChanged for non-select elements from Chosen connection fields

Testing

  • targeted diff review
  • local diagnostics check on touched code path

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Persistent Form’s generic “form content changed” tracking to avoid interfering with Chosen-backed connection fields, relying instead on the existing dedicated .chzn-select change handling and adding a defensive guard in formContentHasChanged.

Changes:

  • Skip the document-level input handler for .kn-input-connection fields that contain a .chzn-select (Chosen-backed connections).
  • Add a backstop in formContentHasChanged to ignore non-<select> events originating from Chosen connection field DOM.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants