Parquet: add row range constraints cache#7478
Draft
siddarth2810 wants to merge 4 commits intocortexproject:masterfrom
Draft
Parquet: add row range constraints cache#7478siddarth2810 wants to merge 4 commits intocortexproject:masterfrom
siddarth2810 wants to merge 4 commits intocortexproject:masterfrom
Conversation
Implement a parquet-common RowRangesForConstraintsCache backed by Cortex cache backends. Encode row ranges into a compact binary format and hash cache keys so they are safe for memcached and other shared cache backends. Signed-off-by: Siddarth Gundu <siddarthg0910@gmail.com>
Add bucket-store config for the parquet row ranges cache, create the backend cache for parquet queryable Signed-off-by: Siddarth Gundu <siddarthg0910@gmail.com>
Signed-off-by: Siddarth Gundu <siddarthg0910@gmail.com>
Signed-off-by: Siddarth Gundu <siddarthg0910@gmail.com>
siddarth2810
changed the title
friedrichg
reviewed
May 6, 2026
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Direction looks good to me. Clean implementation following existing cache patterns. Only minor nit: the cfg.MultiLevel.BackFillTTL = cfg.TTL line in RegisterFlagsWithPrefix is dead code since CreateParquetRowRangesCache re-sets it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
It adds a Cortex-backed implementation of parquet-common's
RowRangesForConstraintsCacheand wires it into the direct parquet queryable path in the querier.Which issue(s) this PR fixes:
Fixes #7139
Implemented:
pkg/util/parquetutilparquet_row_ranges_cachePending:
I am opening this as a draft to confirm the direction before proceeding further.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags