[ENHANCEMENT] ring/backoff: reuse timers in lifecycler and backoff loops#7270
Open
sandy2008 wants to merge 3 commits intocortexproject:masterfrom
Open
[ENHANCEMENT] ring/backoff: reuse timers in lifecycler and backoff loops#7270sandy2008 wants to merge 3 commits intocortexproject:masterfrom
sandy2008 wants to merge 3 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Sandy Chen <Yuxuan.Chen@morganstanley.com>
friedrichg
reviewed
Feb 18, 2026
Member
friedrichg
left a comment
There was a problem hiding this comment.
I am concerned also that unit tests on backoff.go don't cover these changes.
could you add them?
Signed-off-by: Sandy Chen <Yuxuan.Chen@morganstanley.com>
Contributor
Author
|
@friedrichg Oops.. forgot to modernize, let me fix. |
Signed-off-by: Sandy Chen <Yuxuan.Chen@morganstanley.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
time.After(...)calls with reusabletime.Timerinstances in:pkg/ring/lifecycler.gopkg/ring/basic_lifecycler.gopkg/util/backoff/backoff.gostopAndDrainTimer,resetTimer) inpkg/ring/ticker.goto avoid timer channel races/leaks.putRequestsmap capacity inpkg/ring/kv/dynamodb/client.go.Performance validation (local
-benchmem):time.Aftervs reusable timer):248 B/op, 3 allocs/op->0 B/op, 0 allocs/op.time.Afterstyle vs reusable timer):248 B/op, 3 allocs/op->0 B/op, 0 allocs/op.ns/opimprovement in both benchmarks.Which issue(s) this PR fixes:
Similar to #7266
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]