Return remote write v2 stats when request is HA deduped #7240
+100
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
After enabling remote write v2, I am seeing following errors from my Prometheus server.
After investigation, those requests were actually HA deduped so the samples were counted as failure. This is because we return stats of 0 samples written for HA deduped requests because it is considered as an error. However, this is against the expectation of the sender and Prometheus currently treats those samples as failed to send and it won't retry because it is a 202 http accepted status.
To fix this, this PR sets the samples stats in the response to the same value as number of samples in the remote write v2 request.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]