Skip to content

fix(volumeClaimTemplates): add apiVersion and kind to volumeClaimTemplates #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gianvetter wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(volumeClaimTemplates): add apiVersion and kind to volumeClaimTemplates #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e550733
fix(alertmanager, compactor, ingester, store-gateway): add apiVersion…
gianvetter Mar 27, 2026
ee83f89
fix(changelog): add bugfix entry for apiVersion and kind fields in vo…
gianvetter Mar 27, 2026
4566dd1
fix(changelog): update bugfix entry for apiVersion and kind fields in…
gianvetter Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## master / unreleased

* [BUGFIX] Add `apiVersion` and `kind` fields to `volumeClaimTemplates` in StatefulSets to prevent ArgoCD sync flapping #608

## 3.2.0 / 2026-02-26

* [ENHANCEMENT] enable readiness probe on kiwigrid/k8s-sidecar #597
Expand Down
4 changes: 3 additions & 1 deletion templates/alertmanager/alertmanager-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ spec:
{{- end }}
{{- end }}
volumeClaimTemplates:
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
Comment on lines +31 to +33
Copy link
Copy Markdown
Collaborator

@kd7lxl kd7lxl Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official docs do not include the apiVersion and kind fields in the volumeClaimTemplate: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#components

  volumeClaimTemplates:
  - metadata:
      name: www

The drift you are seeing is a bug in ArgoCD, not in this chart.

Copy link
Copy Markdown
Author

@gianvetter gianvetter Mar 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely correct that it's technically an ArgoCD bug.

However, this issue has been open for 3 years (argoproj/argo-cd#16707), and many widely-used charts have already added this workaround to prevent constant drift warnings for ArgoCD users.

For example:

I'd prefer to align this chart with how other charts handle it to improve the experience for ArgoCD users. What do you think?

If you don't think this change is necessary, I can also set up an ignore diff in ArgoCD. That works for me too.

Copy link
Copy Markdown
Collaborator

@kd7lxl kd7lxl Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep usage here inline with the official docs. I welcome other opinions on this topic if anyone else wants to voice them. In the short term, I recommend adding the ignore diff workaround or deploying a fork of this chart.

name: storage
{{- if .Values.alertmanager.persistentVolume.annotations }}
annotations:
Expand Down
4 changes: 3 additions & 1 deletion templates/compactor/compactor-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ spec:
{{- end }}
{{- end }}
volumeClaimTemplates:
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: storage
{{- if .Values.compactor.persistentVolume.annotations }}
annotations:
Expand Down
4 changes: 3 additions & 1 deletion templates/ingester/ingester-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ spec:
{{- end }}
{{- end }}
volumeClaimTemplates:
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: storage
{{- if .Values.ingester.persistentVolume.annotations }}
annotations:
Expand Down
4 changes: 3 additions & 1 deletion templates/store-gateway/store-gateway-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ spec:
{{- end }}
{{- end }}
volumeClaimTemplates:
- metadata:
- apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: storage
{{- if .Values.store_gateway.persistentVolume.annotations }}
annotations:
Expand Down