Fix: added build steps to readme and removed ios warning#63
Open
LasseMunk wants to merge 1 commit intocortex-js:masterfrom
Open
Fix: added build steps to readme and removed ios warning#63LasseMunk wants to merge 1 commit intocortex-js:masterfrom
LasseMunk wants to merge 1 commit intocortex-js:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Arno,
I was puzzled about the warning in the documentation about iOS (safari) not reacting to event.inoutType === 'insertLineBreak'
I was in a discussion from april last year on the discord, that this issue should have been fixed, so I'm making a PR to remove that warning, if it is in fact obsolete. I don't have an apple device, so I can't test if it works or not.
I made a few additions in the readme which I thought was appropriate. Hope it helps :)
Best, Lasse