Skip to content

Conversation

@FedeDR
Copy link
Contributor

@FedeDR FedeDR commented Sep 24, 2014

System test environment and related system test
Fixed some minor bug

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling f77f6e7 on FedeDR:black_box into b6ab2e8 on corso-python-prato:master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non è un po ambiguo chiamarla share_path ? sembra la path della cartella dello share e non della cartella di rawbox no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non ho capito la differenza tra cartella dello share e quella di rawbox...
ho usato il termine share_path per definire la cartella con i file dell'utente che viene sincronizzata col server. Bene o male ho seguito questa terminologia per tutto il codice

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

share_path sembra "RawBox/shares" a meno a me XD l'importante è essere coerenti, nel resto del demone non compare mai share_path, la path di rawbox viene chiamata dir_path, se vuoi cambiarla rinominala ovunque, però secondo me a quel punto è meglio rawbox_dir_path perche abbiamo anche una cartella shares e share_path può essere forviante per quello.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cambiato nomenclatura

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 763adca on FedeDR:black_box into b6ab2e8 on corso-python-prato:master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

è solo una questione stilistica, ma personalmente penso che era più bello (perché più conciso):

return PasswordChecker(password) == password

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo stavo riguardando prima ed ero arrivato alla stessa conclusione. applico la modifica

@GendoIkari
Copy link
Contributor

Instance e non istance :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 7d3c172 on FedeDR:black_box into 754d20b on corso-python-prato:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 9f4e3f8 on FedeDR:black_box into 754d20b on corso-python-prato:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants