fix(ebpf): support Go 1.26 pclntab where pcHeader.textStart is always zero#2
Open
harveywong98 wants to merge 1 commit intocoroot:mainfrom
Open
fix(ebpf): support Go 1.26 pclntab where pcHeader.textStart is always zero#2harveywong98 wants to merge 1 commit intocoroot:mainfrom
harveywong98 wants to merge 1 commit intocoroot:mainfrom
Conversation
… zero Go 1.26 permanently zeroes the textStart field in pcHeader (.gopclntab), so ParseRuntimeTextFromPclntab18 now always returns 0. For pure-Go binaries the old fallback to .text.Addr is correct, but for CGO + external-link binaries C code is placed before runtime.text in .text, making .text.Addr wrong and corrupting all functab PC offsets. Fix: when textStart == 0, look up "runtime.text" from .symtab before falling back to .text.Addr. Adds findRuntimeTextSymbol() for this lookup. Also adds Go 1.26 test binaries (go26, go26-static) and corresponding test cases in TestSelfGoSymbolComparison. Ref: golang/go@0e1bd8b Ref: https://go.dev/doc/go1.26
harveywong98
force-pushed
the
pr/go126-coroot
branch
from
2d9ba2f to
83ea14b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Go 1.26 + CGO binaries produce corrupted flame graphs with wrong function names.
Root Cause
Fix
When pcHeader.textStart == 0, look up runtime.text from .symtab before falling back to .text.Addr:
Tests
Added go26 and go26-static test binaries (Go 1.26) to TestSelfGoSymbolComparison. Verified in production with a Go 1.26 + CGO service.
References
golang/go@0e1bd8b
https://go.dev/doc/go1.26#linker