Button: prevent crashes caused by _isWithinBounds #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a chance that the button's touch event is still called after the button's
view.parenthas already been removed and set to nil. This will result in a runtime error withinfunction widget._isWithinBounds( object, event )when it attempts to index a nil value (i.e.object.contentBoundswithinobjectas it isn't a table anymore).framework-widget/widgetLibrary/widget.lua
Lines 245 to 257 in d425ae7
The safest and easiest way to fix this issue is to just check that the button's
view.parentexists and is still a display object at the start of the touch listener.As a part of these changes, there's no need for further checks to see if the parent view exists given that the function won't get past the new initial check if it doesn't.