fix: Load the palette color from a promise #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note there is a performance issue in this build - it wasn't introduced by these changes, but it 5-10 times slower than earlier versions (not sure how early to go to have it fast - was using 4.0.4
|
✔️ Deploy Preview for cornerstone-wado-image-loader ready! 🔨 Explore the source changes: 8ba0b46 🔍 Inspect the deploy log: https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/62263b04205b730007e78699 😎 Browse the preview: https://deploy-preview-434--cornerstone-wado-image-loader.netlify.app |
sedghi
changed the title
sedghi
reviewed
Aug 3, 2022
| import isJPEGBaseline8BitColor from './isJPEGBaseline8BitColor.js'; | ||
| import { getOptions } from './internal/options.js'; | ||
|
|
||
| /*eslint complexity: ["error", 37]*/ |
sedghi
approved these changes
Aug 3, 2022
Member
sedghi
left a comment
sedghi
left a comment
There was a problem hiding this comment.
minor comments needs to be resolved first, Looks good otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The palette colour data can come back as a promise, so that it is lazy loaded as required.
The conversion from palette colour is fast, but there does seem to be a rerender somewhere that is relatively slow in the newer version - this doesn't seem to be related to the changes here as I can revert them and it is still slow, but version 4.0.4 was faster.
Changed to have the image loader use async instead of promises to deal with a deep nesting of things.