systemv.js change to allow to work with amazon AWS servers#33
Closed
JohnNelsonAPPX wants to merge 2 commits intocoreybutler:masterfrom
JohnNelsonAPPX:master
Closed
systemv.js change to allow to work with amazon AWS servers#33JohnNelsonAPPX wants to merge 2 commits intocoreybutler:masterfrom JohnNelsonAPPX:master
JohnNelsonAPPX wants to merge 2 commits intocoreybutler:masterfrom
JohnNelsonAPPX:master
Conversation
This updated file allows node-linux to work with Amazon AWS servers.
Update systemv.js
|
Note that this is only required until the underlying issue #31 is fixed. |
Owner
|
There are already checks for |
Author
|
My apologies. I actually fixed this 6 months ago, but am new to git. Was revisiting it when I saw I didn't submit the pull request to you like I thought I did, but instead of checking the new code first, I just went ahead and submitted the pull request. |
Owner
|
No worries... I'm happy people are committing! |
|
@coreybutler I submitted a PR (#38), let me know when you get a chance to review it :) |
|
@coreybutler any idea of when you'll have time to review/merge PR #38? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.