Revert "butane: replace LAYOUT with architecture before render"

[travier]

Reverts #4525

This changes does not work for coreos/fedora-coreos-config#4097 (reverted in coreos/fedora-coreos-config#4101) as the Butane config is parsed before the check to not run on s390x is done.

[gemini-code-assist]

Code Review

This pull request simplifies the registerTestDir function in mantle/kola/harness.go by removing the manual substitution of the {{LAYOUT}} placeholder in Butane configurations and the corresponding comment. I have no feedback to provide.

[angelcerveraroldan]

lgtm

[Rolv-Apneseth]

We dropped this from fedora-coreos-config but it's still used in bootupd: https://github.com/coreos/bootupd/blob/main/tests/kola/raid1/config.bu

[Rolv-Apneseth]

I was gonna do the same split over there as we did for fcos, but is it actually worth having it duplicated? Can we just run fcos tests in the bootupd CI? I assume it's just a modification to this line

Edit: Regardless, we can probably revert that {{LAYOUT}} commit in bootupd anyway. I think the CI only runs against x86_64 hence why it wasn't a problem before.

[travier]

Good catch. I agree that we should be able to remove the kola test from the bootupd repo now that it is in the main fedora-coreos-config one. I was looking for an example run but the CI is failing on the bootupd repo right now.

[Rolv-Apneseth]

Good catch. I agree that we should be able to remove the kola test from the bootupd repo now that it is in the main fedora-coreos-config one. I was looking for an example run but the CI is failing on the bootupd repo right now.

Yeah, I believe @yasminvalim is looking into it at the moment