tests/containers/fips-nginx: fix typos and add trap in build.sh#4492
Open
HuijingHei wants to merge 1 commit intocoreos:mainfrom
Open
tests/containers/fips-nginx: fix typos and add trap in build.sh#4492HuijingHei wants to merge 1 commit intocoreos:mainfrom
HuijingHei wants to merge 1 commit intocoreos:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
tests/containers/fips-nginx/build.sh
Outdated
|
|
||
| tmpdir="$(mktemp -d)" | ||
| cp Containerfile ${tmpdir} | ||
| trap 'rm -rf "${tmpdir}"' EXIT |
Contributor
There was a problem hiding this comment.
For better robustness, it's a good practice to change out of the directory that is about to be removed. While rm -rf on the current working directory often works, it's not guaranteed to be portable or successful in all cases (e.g., on certain filesystems or configurations). Changing to the home directory with cd before the rm command ensures the cleanup is more reliable.
Suggested change
| trap 'rm -rf "${tmpdir}"' EXIT | |
| trap 'cd && rm -rf "${tmpdir}"' EXIT |
Member
Author
|
Next time I think better to let gemini review again before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4477