Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is an automated sync from coreos/repo-templates, adding a new ci/shellcheck script for linting shell scripts. The script is generally well-constructed, following good practices. I've identified a couple of areas for improvement related to performance and code clarity. Given that this is a template file, these suggestions should ideally be addressed in the upstream repository to benefit all downstream projects.
Member
|
some golang lint failures. I'll try to take care of them, but it won't be until later. |
dustymabe
force-pushed
the
repo-templates
branch
3 times, most recently
from
8200afd to
64388e8
Compare
dustymabe
changed the title
dustymabe
force-pushed
the
repo-templates
branch
2 times, most recently
from
294eaca to
79d9022
Compare
coreosbot-releng
force-pushed
the
repo-templates
branch
from
79d9022 to
9f43f96
Compare
coreosbot-releng
changed the title
HuijingHei
force-pushed
the
repo-templates
branch
from
9f43f96 to
d2c33e0
Compare
HuijingHei
force-pushed
the
repo-templates
branch
from
6958db1 to
748dfc4
Compare
Member
|
hey @HuijingHei - I'll take this one. I was playing with it last week and got busy but there are a few things that need to happen before I can merge this one. |
14 tasks
dustymabe
added a commit
to dustymabe/coreos-assembler
that referenced
this pull request
Mar 18, 2026
In [1] we configured repo-templates to push the go and shellcheck workflows to the COSA repo. Right now the existing golangci-lint workflow here is failing because of golang versions. Let's just drop the existing lints here prematurely knowing that we are going to move to the new repo-templates provided linters in [2]. [1] coreos/repo-templates#359 [2] coreos#4468
dustymabe
added a commit
that referenced
this pull request
Mar 18, 2026
In [1] we configured repo-templates to push the go and shellcheck workflows to the COSA repo. Right now the existing golangci-lint workflow here is failing because of golang versions. Let's just drop the existing lints here prematurely knowing that we are going to move to the new repo-templates provided linters in [2]. [1] coreos/repo-templates#359 [2] #4468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by GitHub workflow (source).
Sync with coreos/repo-templates@31f11ac.