Fix popup graphic and text overlap on taller screens#7
Open
owenb321 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vertically while anchoring the text layer at a hardcoded
y=125. On tallerplatforms (Emery, Gabbro) the centered graphic shifted past
y=125andoverlapped the title text.
layers_center_in_windownow keeps the graphic in its original centeredposition so authored animations (alarm rings, shredder shreds) still fit on
screen, and places the text directly below the graphic with a 5px gap,
clamped to the screen bottom.
-7vertical offset is preserved.Fixes issue #4