fw/notification: quiet time auto dismiss option

[srwareham]

fw/notification: move quiet time notification setting into a submenu and add a new auto dismiss toggle

Default state for new toggle is to preserve production behavior (quiet mode disables notification auto dismiss)

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Signed-off-by: Sean Wareham ebriouscoding@gmail.com

[jplexer]

maybe instead of a submenu with 2 toggles, we should just have 3 options for the notification setting (show, auto dismiss, hide)

[srwareham]

Thank you! I've force pushed an update to use a tristate instead of the submenu. New values are:

• "On - Persistent" notifications show and do not auto dismiss (default)
• "On - Auto Dismiss" notifications show and auto dismiss
• "Off"

Another cleanup could be to update the string in the phone settings menu, which maybe could instead read "Notifications time out (disappear) after this period (unless persistent Quiet Time notifications are enabled)"

Happy to submit a PR for changing the string in libpebble3 if appropriate

[srwareham]

I'm having a hard time interpreting the automated tests. When I read test-status it seems like it is supposed to fail?

Run exit 1
  exit 1
  shell: /usr/bin/bash -e {0}
  env:
    TEST_BOARD: qemu_gabbro
Error: Process completed with exit code 1.

build-test seems more relevant but I'm having trouble reproducing locally.

/usr/bin/ld: 88dd71395bd71640c3acb277989fb213/src/fw/popups/notifications/notification_window.o: in function `prv_should_pop_due_to_inactivity':
/__w/PebbleOS/PebbleOS/build/test/../../src/fw/popups/notifications/notification_window.c:563:(.text.prv_should_pop_due_to_inactivity+0x47): undefined reference to `alerts_preferences_dnd_get_auto_dismiss'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Build failed
Waf: Leaving directory `/__w/PebbleOS/PebbleOS/build/test'
 -> task in '/__w/PebbleOS/PebbleOS/build/test/tests/fw/ui/test_notification_window_obelix/runme_obelix' failed with exit status 1 (run with -v to display more information)
 -> task in '/__w/PebbleOS/PebbleOS/build/test/tests/fw/ui/test_notification_window_gabbro/runme_gabbro' failed with exit status 1 (run with -v to display more information)
Error: Process completed with exit code 1.

When I try to ls PebbleOS/build/test/tests/fw/ui/ all I see are empty directories. It's not clear to me where there's a test I can run to try to reproduce this error. When I build the firmware for all of the qemu targets everything works fine, so I'm assuming there's some update I need to make to the tests for the tests to link correctly?

[jplexer]

I'm having a hard time interpreting the automated tests. When I read test-status it seems like it is supposed to fail?

Yes, test-status is basically just a "did this test succeed?"

When I try to ls PebbleOS/build/test/tests/fw/ui/ all I see are empty directories. It's not clear to me where there's a test I can run to try to reproduce this error. When I build the firmware for all of the qemu targets everything works fine, so I'm assuming there's some update I need to make to the tests for the tests to link correctly?

./waf test, you are probably missing a stub somewhere

[jplexer]

you also need to rebase onto main, you can just tell claude to do that and the test fixing!

[srwareham]

Rebased on main, added missing stub to fix the test, and squashed into single commit. Hopefully should be good to merge now, thank you for the help!