Skip to content

Upstream sync: port 27 new commits from github/copilot-sdk (2026-03-05)#174

Merged
brunoborges merged 3 commits intomainfrom
copilot/sync-upstream-changes-please-work
Mar 5, 2026
Merged

Upstream sync: port 27 new commits from github/copilot-sdk (2026-03-05)#174
brunoborges merged 3 commits intomainfrom
copilot/sync-upstream-changes-please-work

Conversation

Copy link
Contributor

Copilot AI commented Mar 5, 2026

Ports relevant changes from github/copilot-sdk since last merge (dcd86c14246289).

Before the change?

  • PermissionRequestResult.setKind() only accepted raw String values; no typed constants for well-known permission outcomes
  • E2ETestContext used CI env var for CI detection — wrong variable for GitHub Actions; fake token was not being set in CI
  • Resume session E2E tests did not assert continued stateful conversation after resume
  • StreamingFidelityTest E2E tests were absent; streaming delta coverage lived in a snapshot that was removed upstream
  • No E2E test for getLastSessionId()

After the change?

  • PermissionRequestResultKind — new string-backed value type with well-known constants; case-insensitive equality; Jackson serializes transparently as a string:
new PermissionRequestResult().setKind(PermissionRequestResultKind.APPROVED)
new PermissionRequestResult().setKind(PermissionRequestResultKind.DENIED_COULD_NOT_REQUEST_FROM_USER)
// Backward-compatible: .setKind("approved") still works
  • CI detection fixSystem.getenv("CI")System.getenv("GITHUB_ACTIONS") in E2ETestContext.createClient()
  • Resume tests — both testShouldResumeSessionUsingTheSameClient and testShouldResumeSessionUsingNewClient now assert a follow-up stateful turn after resume; snapshots updated accordingly
  • StreamingFidelityTest — new E2E test class (streaming_fidelity snapshot category) covering: delta events when streaming enabled, no deltas when disabled, deltas after session resume
  • testShouldGetLastSessionId — new E2E test using the session/should_get_last_session_id snapshot
  • Removed two tests whose snapshots were deleted upstream (should_receive_streaming_delta_events_when_streaming_is_enabled, should_pass_streaming_option_to_session_creation)
  • advanced.md Permission Handling section updated with PermissionRequestResultKind constant table

Not ported

Commit Reason
2951807 .NET build infra + docs .NET-specific; Java Javadoc already more complete
4246289 Go remove hand-written PermissionRequest Go-specific
5b4a6ec Update @github/copilot to 0.0.421 Node.js dep; Java tests clone upstream for CLI
207b85b Python timeout in generated RPC methods Python-specific
87a54de/b49e5d8/c13dbba GitHub Actions runtime triage workflows
2fc65b4e9797ca Dependabot/dep bumps (Node.js, actions)
760ba65 custom agents guide Existing Java SDK docs already cover this

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • mvn spotless:apply has been run to format the code
  • mvn clean verify passes locally

Does this introduce a breaking change?

  • Yes
  • No

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-a0b8ba07f7cabbfc/dbs/java/working/files-to-index723148437249810622.list --sourceArchiveDir=/tmp/codeql-scratch-a0b8ba07f7cabbfc/dbs/java/src --outputDir=/tmp/codeql-scratch-a0b8ba07f7cabbfc/dbs/java/trap/java va/copilot-sdk-java/src/test/java/com/github/copilot/sdk/SessionEventsE2ETest.java sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits March 5, 2026 20:11
… E2E test updates

Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Copilot AI changed the title [WIP] Sync with upstream repository for new commits Upstream sync: port 27 new commits from github/copilot-sdk (2026-03-05) Mar 5, 2026
@brunoborges brunoborges marked this pull request as ready for review March 5, 2026 20:28
@brunoborges brunoborges requested a review from edburns as a code owner March 5, 2026 20:28
@edburns
Copy link
Collaborator

edburns commented Mar 5, 2026

Metric Main PR Delta
Instructions 88.5% 88.8% +0.3%
Branches 82.5% 82.5% 0.0%
Lines 89.3% 89.6% +0.3%
Tests 404 420 +16

JaCoCo coverage comparison. Looks good.

@brunoborges brunoborges merged commit 5df5754 into main Mar 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants