Skip to content

Custom where condition for NetteDatabaseDataSource#1283

Open
vcernik wants to merge 2 commits intocontributte:masterfrom
vcernik:feature/NetteDatabaseDataSource-condition
Open

Custom where condition for NetteDatabaseDataSource#1283
vcernik wants to merge 2 commits intocontributte:masterfrom
vcernik:feature/NetteDatabaseDataSource-condition

Conversation

@vcernik
Copy link
Copy Markdown

@vcernik vcernik commented May 5, 2026

Adds custom where condition for NetteDatabaseDataSource

@radimvaculik
Copy link
Copy Markdown
Member

LGTM. But seems like breaking change.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.97%. Comparing base (e5faff0) to head (ed8914d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
+ Coverage   46.79%   46.97%   +0.18%     
==========================================
  Files          53       53              
  Lines        2729     2729              
==========================================
+ Hits         1277     1282       +5     
+ Misses       1452     1447       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot <copilot@github.com>
@vcernik
Copy link
Copy Markdown
Author

vcernik commented May 5, 2026

Yes, it seems. But when previous getDataSource returns Explorer, it's completely useless - there is no logical connection to object NetteDatabaseDataSource.

I hope I'm making myself clear. I'm excited - this is my first PR :D Thank you for this awesome Datagrid! Hezký den ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants