fix: pass GITHUB_TOKEN to vscode e2e tests for ripgrep download #9755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @vscode/ripgrep package requires authentication when downloading from GitHub's API to avoid rate limiting (403 errors). This was causing flaky test failures in vscode-e2e-tests. Added github_token input to the run-vscode-e2e-test action and pass CI_GITHUB_TOKEN to the e2e tests in pr-checks.yaml. Generated with Continue Co-Authored-By: Continue <noreply@continue.dev> Co-authored-by: isabensusan <isabensusan@gmail.com>
continue-staging
bot
requested review from
RomneyDa
and removed request for
a team
dosubot
bot
added
the
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
e2e/_output/tests/Edit.test.js (e2e:ci:run-yaml)test was failing due to a GitHub API rate limit error (403) when downloading@vscode/ripgrep.Root Cause
The
@vscode/ripgreppackage requires authentication when downloading from GitHub's API to avoid rate limiting. The e2e test action was not passing aGITHUB_TOKENto the npm install step, causing intermittent 403 errors.Changes
.github/actions/run-vscode-e2e-test/action.yml: Addedgithub_tokeninput parameter and set it asGITHUB_TOKENenvironment variable in the npm ci step.github/workflows/pr-checks.yaml: PassCI_GITHUB_TOKENto the e2e test actionError from CI logs
This task was co-authored by isabensusan and Continue.
Continue Tasks
Powered by Continue
Summary by cubic
Pass a GitHub token to VSCode e2e tests so ripgrep downloads are authenticated, preventing 403 rate limit failures. This stabilizes the CI e2e run.
Written for commit e627eb7. Summary will update on new commits.