Skip to content

fix: retrieve reasoning toggle from local storage #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uinstinct wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −5
Open

fix: retrieve reasoning toggle from local storage #9688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gui/src/components/mainInput/InputToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { selectSelectedChatModel } from "../../redux/slices/configSlice";
import { setHasReasoningEnabled } from "../../redux/slices/sessionSlice";
import { exitEdit } from "../../redux/thunks/edit";
import { getMetaKeyLabel, isMetaEquivalentKeyPressed } from "../../util";
import { setLocalStorage } from "../../util/localStorage";
import { ToolTip } from "../gui/Tooltip";
import ModelSelect from "../modelSelection/ModelSelect";
import { ModeSelect } from "../ModeSelect";
Expand Down Expand Up @@ -136,9 +137,10 @@ function InputToolbar(props: InputToolbarProps) {
)}
{supportsReasoning && (
<HoverItem
onClick={() =>
dispatch(setHasReasoningEnabled(!hasReasoningEnabled))
}
onClick={() => {
dispatch(setHasReasoningEnabled(!hasReasoningEnabled));
setLocalStorage("hasReasoningEnabled", !hasReasoningEnabled);
}}
>
<ToolTip
place="top"
Expand Down
10 changes: 8 additions & 2 deletions gui/src/hooks/ParallelListeners.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
setDocumentStylesFromTheme,
} from "../styles/theme";
import { isJetBrains } from "../util";
import { setLocalStorage } from "../util/localStorage";
import { getLocalStorage, setLocalStorage } from "../util/localStorage";
import { migrateLocalStorage } from "../util/migrateLocalStorage";
import { useWebviewListener } from "./useWebviewListener";

Expand Down Expand Up @@ -88,8 +88,14 @@ function ParallelListeners() {
const supportsReasoning = modelSupportsReasoning(chatModel);
const isReasoningDisabled =
chatModel?.completionOptions?.reasoning === false;
const wasReasoningPreviouslyEnabled =
getLocalStorage("hasReasoningEnabled") !== false;
dispatch(
setHasReasoningEnabled(supportsReasoning && !isReasoningDisabled),
setHasReasoningEnabled(
supportsReasoning &&
!isReasoningDisabled &&
wasReasoningPreviouslyEnabled,
),
);
},
[dispatch, hasDoneInitialConfigLoad, selectedProfileId],
Expand Down
1 change: 1 addition & 0 deletions gui/src/util/localStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ type LocalStorageTypes = {
disableIndexing: boolean;
hasExitedFreeTrial: boolean;
hasDismissedCliInstallBanner: boolean;
hasReasoningEnabled: boolean;
};

export enum LocalStorageKey {
Expand Down
Loading