-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: add n1n provider #9614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add n1n provider #9614
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 4 files
ac7695f to
6a21223
Compare
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/cli/vitest.config.ts">
<violation number="1" location="extensions/cli/vitest.config.ts:28">
P2: Alias uses URL.pathname instead of fileURLToPath, producing URL-encoded/Windows-incompatible paths and risking failed alias resolution</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
@cubic-dev-ai fix |
|
I've fixed the issue in Changes made:
This ensures proper cross-platform path handling, especially on Windows where diff --git a/extensions/cli/vitest.config.ts b/extensions/cli/vitest.config.ts
index 691b8f5..a076e01 100644
--- a/extensions/cli/vitest.config.ts
+++ b/extensions/cli/vitest.config.ts
@@ -1,3 +1,4 @@
+import { fileURLToPath } from "url";
import { defineConfig } from "vitest/config";
export default defineConfig({
@@ -25,8 +26,8 @@ export default defineConfig({
extensions: [".js", ".ts", ".tsx", ".json"],
alias: {
// Map core imports to the core source file since index.ts doesn't exist
- "../../../../../core/index.js": new URL("../../core/core.ts", import.meta.url).pathname,
- "core/index.js": new URL("../../core/core.ts", import.meta.url).pathname,
+ "../../../../../core/index.js": fileURLToPath(new URL("../../core/core.ts", import.meta.url)),
+ "core/index.js": fileURLToPath(new URL("../../core/core.ts", import.meta.url)),
},
},
});
Files changed:
|
|
@cubic-dev-ai fix failed test |
|
I've fixed the issue in Changes made:
This ensures proper cross-platform path handling, especially on Windows where diff --git a/extensions/cli/vitest.config.ts b/extensions/cli/vitest.config.ts
index 691b8f5..a076e01 100644
--- a/extensions/cli/vitest.config.ts
+++ b/extensions/cli/vitest.config.ts
@@ -1,3 +1,4 @@
+import { fileURLToPath } from "url";
import { defineConfig } from "vitest/config";
export default defineConfig({
@@ -25,8 +26,8 @@ export default defineConfig({
extensions: [".js", ".ts", ".tsx", ".json"],
alias: {
// Map core imports to the core source file since index.ts doesn't exist
- "../../../../../core/index.js": new URL("../../core/core.ts", import.meta.url).pathname,
- "core/index.js": new URL("../../core/core.ts", import.meta.url).pathname,
+ "../../../../../core/index.js": fileURLToPath(new URL("../../core/core.ts", import.meta.url)),
+ "core/index.js": fileURLToPath(new URL("../../core/core.ts", import.meta.url)),
},
},
});
Files changed:
|
Add n1n.ai as an OpenAI-compatible provider. This implementation includes core provider logic and GUI configuration updates to make n1n models easily accessible.
Continue Tasks
Powered by Continue
Summary by cubic
Adds N1N as an OpenAI-compatible provider with backend support and GUI integration, so users can run GPT-4o and Claude models via n1n.ai. Includes new presets and provider selection in Add New Model.
Written for commit 6b04245. Summary will update on new commits.