-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(cli): add SSL verification option for client transports #9551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add support for disabling SSL verification when verifySsl flag is false by providing a custom HTTPS agent. This allows connections to servers with self-signed certificates or in development environments where SSL verification needs to be bypassed.
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| const sseAgent = | ||
| serverConfig.requestOptions?.verifySsl === false | ||
| ? new HttpsAgent({ rejectUnauthorized: false }) | ||
| : undefined; |
Check failure
Code scanning / CodeQL
Disabling certificate validation High
| const streamableAgent = | ||
| serverConfig.requestOptions?.verifySsl === false | ||
| ? new HttpsAgent({ rejectUnauthorized: false }) | ||
| : undefined; |
Check failure
Code scanning / CodeQL
Disabling certificate validation High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
|
@RomneyDa @sestinj I noticed that the lint errors were not introduced by this PR. I am more than happy to fix these lints. > @continuedev/cli@0.0.0-dev lint
> tsc --noEmit && eslint .
/home/runner/work/continue/continue/extensions/cli/src/services/MCPService.ts
Error: 622:1 error File has too many lines (515). Maximum allowed is 500 max-lines
✖ 1 problem (1 error, 0 warnings)
Error: Process completed with exit code 1. |

Description
Add support for disabling SSL verification when verifySsl flag is false by providing a custom HTTPS agent. This allows connections to servers with self-signed certificates or in development environments where SSL verification needs to be bypassed.
ref: #6215
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks
Powered by Continue
Summary by cubic
Adds an optional SSL bypass for MCP SSE and HTTP client transports. When requestOptions.verifySsl is false, connections to self-signed or dev servers work; default behavior remains unchanged.
Written for commit 173b9db. Summary will update on new commits.