-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: show message counter in history page #9524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
uinstinct
wants to merge
1
commit into
continuedev:main
Choose a base branch
from
uinstinct:history-counter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| import { | ||
| ArrowDownOnSquareIcon, | ||
| CloudIcon, | ||
| PencilSquareIcon, | ||
| TrashIcon, | ||
| CloudIcon, | ||
| } from "@heroicons/react/24/outline"; | ||
| import { BaseSessionMetadata } from "core"; | ||
| import type { RemoteSessionMetadata } from "core/control-plane/client"; | ||
|
|
@@ -22,6 +22,7 @@ import { | |
| } from "../../redux/thunks/session"; | ||
| import { isShareSessionSupported } from "../../util"; | ||
| import HeaderButtonWithToolTip from "../gui/HeaderButtonWithToolTip"; | ||
| import { ToolTip } from "../gui/Tooltip"; | ||
|
|
||
| const shareSessionSupported = isShareSessionSupported(); | ||
|
|
||
|
|
@@ -144,6 +145,18 @@ export function HistoryTableRow({ | |
| Remote | ||
| </span> | ||
| )} | ||
|
|
||
| {sessionMetadata.messageCount !== undefined && ( | ||
| <ToolTip | ||
| content={`${sessionMetadata.messageCount} message${ | ||
| sessionMetadata.messageCount === 1 ? " is" : "s are" | ||
| } present in this session`} | ||
| > | ||
| <span className="bg-vsc-background text-secondary-foreground ml-auto inline-flex items-center rounded-full px-2 py-1 text-xs font-medium"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Message counter is placed at the right edge ( Prompt for AI agents |
||
| {sessionMetadata.messageCount} | ||
| </span> | ||
| </ToolTip> | ||
| )} | ||
| </div> | ||
| )} | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for longer agent conversations this will show a number much lower than it should e.g. 1 user message, 20 assistant/tool messages will show 1
Maybe we could count conversational turns or just simple chatHistory.length excluding system message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually when trying out
chatHistory.length, it show around 15 counter for a single message conversation which would include tool calls and assistant messages. I think the user will want to know how many followups he did.@RomneyDa what do you think about replacing the message counter with dots or bars? something like
| | |indicating 3 messages or• • •or● ● ●. when there are more than 7-8 messages (depending on the sidebar width), it will show the counter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's currently counting by filtering for
usermessages, am I reading that wrong?Personally I prefer a little number with message icon or similar to dots or bars but I don't have super strong opinions about the design!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes only user messages.
How about putting dots for the initial design? If they do not look good, it can be changed