Skip to content

fix(cli): report missing npm during install #12268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyphercodes wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −3
Open

fix(cli): report missing npm during install #12268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions extensions/cli/scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,35 @@ add_to_profile() {
grep -q "$check" "$SHELL_PROFILE" 2>/dev/null || echo "$line" >> "$SHELL_PROFILE"
}

get_npm_prefix() {
if ! command -v npm &>/dev/null; then
error "Node.js was found but npm is missing or misconfigured. Please install npm or reinstall Node.js with npm support."
fi

local npm_prefix
if ! npm_prefix="$(npm config get prefix 2>/dev/null)" || [ -z "$npm_prefix" ]; then
error "Node.js was found but npm is missing or misconfigured. Unable to read npm's global prefix."
fi

case "$npm_prefix" in
/|/bin|/usr/bin)
error "Node.js was found but npm is missing or misconfigured. npm global prefix resolved to '$npm_prefix'."
;;
esac

printf "%s\n" "$npm_prefix"
}

setup_npm_path() {
local npm_bin
npm_bin="$(npm config get prefix 2>/dev/null)/bin"
local npm_prefix npm_bin
npm_prefix="$(get_npm_prefix)"
npm_bin="$npm_prefix/bin"
[ -d "$npm_bin" ] && export PATH="$npm_bin:$PATH"
}

check_npm_permissions() {
local npm_prefix
npm_prefix="$(npm config get prefix 2>/dev/null)"
npm_prefix="$(get_npm_prefix)"

# Check if we can write to npm global directory
if [ -d "$npm_prefix/lib" ] && [ ! -w "$npm_prefix/lib" ]; then
Expand Down
Loading