Skip to content

fix: remove hardcoded Unix $ prompt prefix from terminal UI #11429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shanevcantwell wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix: remove hardcoded Unix $ prompt prefix from terminal UI #11429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gui/src/components/UnifiedTerminal/UnifiedTerminal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe("UnifiedTerminalCommand", () => {
);

// Should show the command
expect(screen.getByText(`$ ${MOCK_COMMAND}`)).toBeInTheDocument();
expect(screen.getByText(MOCK_COMMAND)).toBeInTheDocument();

// Should show terminal header
expect(screen.getByText("Terminal")).toBeInTheDocument();
Expand All @@ -68,7 +68,7 @@ describe("UnifiedTerminalCommand", () => {
);

// Should show the command and output
expect(screen.getByText(`$ ${MOCK_COMMAND}`)).toBeInTheDocument();
expect(screen.getByText(MOCK_COMMAND)).toBeInTheDocument();

// Check that the output content exists in the container
expect(container.textContent).toMatch(/Test 1 passed/);
Expand Down Expand Up @@ -303,7 +303,7 @@ describe("UnifiedTerminalCommand", () => {
);

// Should show command but no output section
expect(screen.getByText(`$ ${MOCK_COMMAND}`)).toBeInTheDocument();
expect(screen.getByText(MOCK_COMMAND)).toBeInTheDocument();

// Should not show any output content
const outputElements = container.querySelectorAll(
Expand Down
4 changes: 2 additions & 2 deletions gui/src/components/UnifiedTerminal/UnifiedTerminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ export function UnifiedTerminalCommand({

// Create combined content for copying (command + output)
const copyContent = useMemo(() => {
let content = `$ ${command}`;
let content = command;
if (hasOutput) {
content += `\n\n${output}`;
}
Expand Down Expand Up @@ -459,7 +459,7 @@ export function UnifiedTerminalCommand({
<pre className="bg-editor">
<code>
{/* Command is always visible */}
<div className="text-terminal pb-2">$ {command}</div>
<div className="text-terminal pb-2">{command}</div>

{/* Running state with cursor */}
{isRunning && !hasOutput && (
Expand Down
Loading