Fix stale Models docs links in config panel#11136
Open
siewcapital wants to merge 2 commits intocontinuedev:mainfrom
Open
Fix stale Models docs links in config panel#11136siewcapital wants to merge 2 commits intocontinuedev:mainfrom
siewcapital wants to merge 2 commits intocontinuedev:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
RomneyDa
requested changes
Mar 10, 2026
Collaborator
RomneyDa
left a comment
There was a problem hiding this comment.
@siewcapital thanks for the link fixes!
Could you update the tests to use imported MODEL_DOCS_URLS or similar to prevent 2 sources of truth? Or feel free to remove the test file in this case.
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
@RomneyDa Makes total sense to avoid duplicating the source of truth. I've gone ahead and just dropped the test file entirely as you suggested, which keeps things clean and simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ide-extensions/.../quick-startdocs routeside-extensions/.../model-setup/docs/Why
The links in the Models panel were still pointing at older paths. This aligns the UI with the current docs structure and prevents regressions.
Closes #11126.
Validation
npm test -- src/pages/config/sections/ModelsSection.test.tsx(fromgui/) → fails in this local env due to unresolved transitive module imports from core test graph (partial-json)git diff --checkSummary by cubic
Fixes stale docs links in the Models config panel by switching all "Learn more" and model setup URLs to the current
ide-extensions/.../quick-startandide-extensions/.../model-setuproutes, centralizing them inMODEL_DOCS_URLS, and removing a redundant test to avoid duplicate truth. Closes #11126.Written for commit 3e44346. Summary will update on new commits.