fix: missing cmf-demo main.go file and gitignore fix that missed it.#52
Open
terylt wants to merge 1 commit into
Open
fix: missing cmf-demo main.go file and gitignore fix that missed it.#52terylt wants to merge 1 commit into
terylt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discovered
examples/go-demo/cmd/cmf-demo/main.gowas missing from GitHubeven though it existed locally and
git statusdidn't flag it asuntracked. Root cause:
examples/go-demo/.gitignorehad a bare patterncmf-demomeant to ignore the built binary at the demo root, butgitignore matches bare patterns against any path component at any
depth — so
cmd/cmf-demo/(the source directory) and everythingunder it were silently ignored too.
Same footgun exists in the root
.gitignorefor several other commonnames (
jwt/,build/,lib/,certs/,public/,tmp) thatwould similarly hide future source directories. The
jwt/one isparticularly load-bearing — upcoming JWT-validator work needs
jwt/modules.
Changes
examples/go-demo/.gitignore: anchorcpex-demoandcmf-demowith leading
/so they only match the built binaries at the demoroot. Add explicit
/cmd/cmf-demo/cmf-demofor the binary that livesalongside the source.
.gitignore: anchorcerts/,public/,build/,lib/to/;remove
jwt/entirely; remove baretmp(covered bytemp/); dropduplicate entries for
certs/,public/,build/. Commentsdocument the anchoring rationale.