Skip to content

fix: rt-531 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreya-kamble merged 2 commits into from
Jul 8, 2025
Merged

fix: rt-531 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cda183
fix: rt-531
shreya-kamble Jun 12, 2025
f12235e
Update package.json
shreya-kamble Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@contentstack/json-rte-serializer",
"version": "3.0.2",
"version": "3.0.3",
"description": "This Package converts Html Document to Json and vice-versa.",
"main": "lib/index.js",
"module": "lib/index.mjs",
Expand Down
3 changes: 1 addition & 2 deletions src/toRedactor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const ELEMENT_TYPES: IJsonToHtmlElementTags = {
return `<ul${attrs}>${child}</ul>`
},
code: (attrs: any, child: any) => {
return `<pre${attrs}>${child}</pre>`
return `<pre${attrs}>${child.replace(/<br\/?>/g, '\n')}</pre>`
},
li: (attrs: any, child: any) => {
return `<li${attrs}>${child}</li>`
Expand Down Expand Up @@ -602,7 +602,6 @@ export const toRedactor = (jsonValue: any,options?:IJsonToHtmlOptions) : string
figureStyles
)
}

return children
}

Expand Down
5 changes: 5 additions & 0 deletions test/toRedactor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,3 +348,8 @@ test("should add nbsp for empty blocks", () => {
expect(html).toBe(`<p>Hi</p><p>&nbsp;</p><p>&nbsp;</p><p>Hello</p>`);
});

test("should convert codeblock to proper html, where \n should not be replaced with <br/>",()=>{
const json = {"type":"doc","uid":"uid","attrs":{},"children":[{"type":"code","attrs":{},"uid":"uid","children":[{"text":"Hi\nHello"}]}]};
const html = toRedactor(json);
expect(html).toBe(`<pre>Hi\nHello</pre>`);
})
Loading