Skip to content

Conversation

@aman19K
Copy link
Contributor

@aman19K aman19K commented Jul 16, 2025

No description provided.

@aman19K aman19K requested a review from a team as a code owner July 16, 2025 09:40
@aman19K aman19K marked this pull request as draft July 16, 2025 09:40
cs-raj
cs-raj previously approved these changes Jul 16, 2025
sunil-lakshman
sunil-lakshman previously approved these changes Jul 17, 2025
Copy link
Contributor

@sunil-lakshman sunil-lakshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aman19K aman19K requested a review from Copilot July 17, 2025 06:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the pending global field update workflow by ensuring pending global fields are written and processed at the correct stages.

  • Bump versions across CLI and related plugins to 1.43.1 / 1.25.1
  • Clear placeholder description in global-field schema template
  • Move and guard writes of pending GF file, add informative logs
  • Refactor BaseClass update logic to use async/await and cloneDeep

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/contentstack/package.json Bumped CLI version to 1.43.1
packages/contentstack/README.md Updated CLI version and default data-dir path
packages/contentstack-seed/package.json Bumped cm-import dependency to ~1.25.1
packages/contentstack-import/src/utils/global-field-helper.ts Cleared schema description placeholder
packages/contentstack-import/src/import/modules/global-fields.ts Moved pending GF file write after updates, added log
packages/contentstack-import/src/import/modules/content-types.ts Added pre-check for pending GFs and log count
packages/contentstack-import/src/import/modules/base-class.ts Refactored update sequence to async/await with cloneDeep
packages/contentstack-import/package.json Bumped import plugin version to 1.25.1
packages/contentstack-import/README.md Updated import plugin version in README
packages/contentstack-clone/package.json Updated cm-import dependency to ~1.25.1
packages/contentstack-clone/README.md Updated clone plugin version in README
.talismanrc Updated checksums
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/contentstack-import/src/utils/global-field-helper.ts:25

  • [nitpick] The schema description is now empty. Provide a meaningful description or remove the property to avoid unclear or missing metadata.
        "description": ""

packages/contentstack/README.md:3777

  • [nitpick] The default path and its description are split awkwardly across lines. Consider merging them into a single line or adjusting indentation for clearer formatting.
  -d, --data-dir=<value>  [default: /Users/aman.kumar/Documents/cli-repos/cli-latest/cli/packages/contentstack] Current

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@aman19K aman19K dismissed stale reviews from sunil-lakshman and cs-raj via c0d01df July 17, 2025 06:11
@aman19K aman19K marked this pull request as ready for review July 17, 2025 09:10
cs-raj
cs-raj previously approved these changes Jul 17, 2025
@harshithad0703 harshithad0703 merged commit ce71ebd into main Jul 17, 2025
10 checks passed
@harshithad0703 harshithad0703 deleted the hotfix/DX-3274 branch July 17, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants