-
Notifications
You must be signed in to change notification settings - Fork 16
fix: pending global field update issue #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sunil-lakshman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the pending global field update workflow by ensuring pending global fields are written and processed at the correct stages.
- Bump versions across CLI and related plugins to 1.43.1 / 1.25.1
- Clear placeholder description in global-field schema template
- Move and guard writes of pending GF file, add informative logs
- Refactor BaseClass update logic to use async/await and cloneDeep
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/contentstack/package.json | Bumped CLI version to 1.43.1 |
| packages/contentstack/README.md | Updated CLI version and default data-dir path |
| packages/contentstack-seed/package.json | Bumped cm-import dependency to ~1.25.1 |
| packages/contentstack-import/src/utils/global-field-helper.ts | Cleared schema description placeholder |
| packages/contentstack-import/src/import/modules/global-fields.ts | Moved pending GF file write after updates, added log |
| packages/contentstack-import/src/import/modules/content-types.ts | Added pre-check for pending GFs and log count |
| packages/contentstack-import/src/import/modules/base-class.ts | Refactored update sequence to async/await with cloneDeep |
| packages/contentstack-import/package.json | Bumped import plugin version to 1.25.1 |
| packages/contentstack-import/README.md | Updated import plugin version in README |
| packages/contentstack-clone/package.json | Updated cm-import dependency to ~1.25.1 |
| packages/contentstack-clone/README.md | Updated clone plugin version in README |
| .talismanrc | Updated checksums |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/contentstack-import/src/utils/global-field-helper.ts:25
- [nitpick] The schema description is now empty. Provide a meaningful description or remove the property to avoid unclear or missing metadata.
"description": ""
packages/contentstack/README.md:3777
- [nitpick] The default path and its description are split awkwardly across lines. Consider merging them into a single line or adjusting indentation for clearer formatting.
-d, --data-dir=<value> [default: /Users/aman.kumar/Documents/cli-repos/cli-latest/cli/packages/contentstack] Current
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.