Fix TypeScript build errors, dependency issues, and bump CLI version to 1.41.2 #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafeeqd959
reviewed
Jul 3, 2025
| const { title, uid } = entry; | ||
| // NOTE Remove from list if any entry import failed | ||
| remove(this.entriesForVariant, { locale, entry_uid: uid }); | ||
| this.entriesForVariant = this.entriesForVariant.filter(entry => !(entry.locale === locale && entry.entry_uid === uid)); |
Contributor
There was a problem hiding this comment.
why did we remove this method and added inline code
Contributor
Author
There was a problem hiding this comment.
Hi Shafeeq,
I replaced the lodash remove method with the native .filter() approach to avoid mutating the original array. The new code is more predictable, aligns with modern JavaScript/TypeScript best practices, and improves code safety by ensuring immutability.
Contributor
|
need to push latest package-lock file, please run "npm run setup-repo" on local. |
Contributor
Author
|
Closing this PR due to version conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] TypeScript Build & Dependency Issues in Contentstack CLI Monorepo
Summary
This PR resolves all TypeScript build errors and missing dependency issues that were causing CI/CD failures in the Contentstack CLI monorepo (oclif v4, pnpm, TypeScript). The main focus was on the
contentstack-importpackage, but fixes were applied across all affected packages.Key Changes
entries.tsby replacing problematic Lodashremovecalls with nativeArray.filterfor type safety and compatibility.tslib,@types/lodash, etc.) in all packages that required them.prepackscripts to usepnpm run compilefor consistency and correct argument forwarding.pnpm run prepack) now completes successfully with no TypeScript errors.Testing
pnpm run prepackat the monorepo root; all packages build and generate manifests/readmes as expected.