Skip to content

Conversation

@netrajpatel
Copy link
Contributor

  • Added AWS AU support in other internal CLI plugins
  • Updated test cases
  • Replaced NA and EU with AWS-NA and AWS-EU in all internal CLI plugins

@netrajpatel netrajpatel requested review from aman19K and Copilot June 12, 2025 11:46
@netrajpatel netrajpatel assigned cs-raj and unassigned cs-raj Jun 12, 2025

This comment was marked as outdated.

@netrajpatel netrajpatel changed the base branch from development to feat/dx-3117 June 24, 2025 09:49
@netrajpatel netrajpatel marked this pull request as ready for review June 24, 2025 09:59
@netrajpatel netrajpatel requested a review from a team as a code owner June 24, 2025 09:59
@netrajpatel netrajpatel requested a review from Copilot June 24, 2025 10:01

This comment was marked as outdated.

@netrajpatel netrajpatel requested a review from Copilot June 24, 2025 12:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for AWS-AU (and other new regions) across internal CLI plugins by replacing generic region codes (NA, EU) with provider-specific codes (AWS-NA, AWS-EU) and adding AWS-AU, GCP regions, then updating tests and bumping dependent package versions.

  • Replaced region defaults and mappings from “NA”/“EU” to “AWS-NA”/“AWS-EU” and added AWS-AU, GCP-NA, GCP-EU in config and helper files
  • Updated integration and unit tests to import REGION_MAP and reference provider-specific region codes
  • Bumped versions for related packages and updated CLI README snippets

Reviewed Changes

Copilot reviewed 51 out of 53 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/contentstack-config/src/utils/region-handler.ts Default region and JSDoc updated for AWS-NA/EU
packages/contentstack-import/src/config/index.ts personalize.baseURL key changed to AWS-NA
packages/contentstack-export/src/config/index.ts personalize.baseURL key changed to AWS-NA
packages/contentstack-import/test/config.json Expanded REGIONS list and added REGION_MAP
packages/contentstack-export/test/config.json Expanded REGIONS list
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/contentstack-config/src/utils/region-handler.ts:116

  • [nitpick] The JSDoc lists valid regions as AWS-NA and AWS-EU but omits AWS-AU. Update the comment to reflect all supported regions.
   * @param {string} region It Can be AWS-NA, AWS-EU

packages/contentstack-import/test/config.json:29

  • While the REGIONS list includes AWS-AU, there are no tests that explicitly set or validate AWS-AU behavior. Consider adding integration tests for the AWS-AU path to ensure it works as intended.
  "REGIONS": ["AWS-NA", "AWS-EU", "AWS-AU", "AZURE-NA", "AZURE-EU", "GCP-NA", "GCP-EU"],

@netrajpatel netrajpatel merged commit 7aa252d into feat/dx-3117 Jun 24, 2025
8 checks passed
@netrajpatel netrajpatel deleted the feat/dx-3118 branch June 24, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants