-
Notifications
You must be signed in to change notification settings - Fork 16
Added AWS-AU region support in config command #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added AWS AU support in other CLI commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the CLI’s region support by adding the new AWS-AU region everywhere it’s used: configuration commands, helper utilities, integration tests, and documentation.
- Added AWS-AU (and related GCP-EU/GCP-NA) entries to region handler, interactive prompts, config mappings, and personalize endpoints.
- Refactored integration tests to import a centralized
REGION_MAPand initialize new regions. - Bumped package versions, updated README usage examples, and cleaned up test stubs.
Reviewed Changes
Copilot reviewed 68 out of 72 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/contentstack-config/src/utils/region-handler.ts | Added AU and AWS-AU in region definitions |
| packages/contentstack-config/src/utils/interactive.ts | Updated region choices for prompts |
| packages/contentstack-config/messages/index.json | Default region message updated to AWS-NA |
| packages/contentstack-utilities/messages/config.json | Default region message updated to AWS-NA |
| packages/contentstack-utilities/src/helpers.ts | Normalized path sanitization formatting |
| packages/contentstack-config/test/unit/commands/region.test.ts | Expanded unit tests for AWS-* regions and removed old stubs |
| packages/contentstack-import/src/config/index.ts | Extended personalize baseURL mapping for new regions |
| packages/contentstack-import/test/integration/config.json | Included AWS-AU in test configurations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/contentstack-config/src/utils/interactive.ts:9
- The code still accepts plain 'AU' in the region handler but the interactive choices no longer include {name: 'AU', value: 'AU'}. For consistency, either add the plain 'AU' choice here or remove support for 'AU' in the handler.
{ name: 'AWS-NA', value: 'AWS-NA' },
No description provided.