Skip to content

Fix: Added check for removing field #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs-raj merged 2 commits into from
Apr 23, 2025
Merged

Fix: Added check for removing field #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9b9578
Fix: Added check for removing field
cs-raj Apr 23, 2025
1291a7e
Merge branch 'development' into fix/DX-2894
cs-raj Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/contentstack-audit/src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const config = {
'field-rules',
],
'fix-fields': ['reference', 'global_field', 'json:rte', 'json:extension', 'blocks', 'group', 'content_types'],
'schema-fields-data-type': ['blocks','group','global_field'],
moduleConfig: {
'content-types': {
name: 'content type',
Expand Down
10 changes: 7 additions & 3 deletions packages/contentstack-audit/src/modules/content-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ export default class ContentType {
field.schema = this.runFixOnSchema(tree, field.schema as ContentTypeSchemaType[]);
}
for (let child of field.schema ?? []) {

if (!fixTypes.includes(child.data_type) && child.data_type !== 'json') continue;

switch (child.data_type) {
Expand Down Expand Up @@ -487,8 +486,13 @@ export default class ContentType {
})
.filter((val: any) => {
if (this.config.skipFieldTypes.includes(val?.data_type)) return true;
if (val?.schema && isEmpty(val?.schema)) return false;
if (val?.reference_to && isEmpty(val?.reference_to) && val.data_type==='reference') return false;
if (
val?.schema &&
isEmpty(val?.schema) &&
(!val?.data_type || this.config['schema-fields-data-type'].includes(val.data_type))
)
return false;
if (val?.reference_to && isEmpty(val?.reference_to) && val.data_type === 'reference') return false;

return !!val;
}) as ContentTypeSchemaType[];
Expand Down
Loading