Skip to content

Refine GA4 advanced matching follow-up UX []#10955

Open
zacharyyankiver wants to merge 9 commits into
stagingfrom
codex/ga4-ben-followups
Open

Refine GA4 advanced matching follow-up UX []#10955
zacharyyankiver wants to merge 9 commits into
stagingfrom
codex/ga4-ben-followups

Conversation

@zacharyyankiver
Copy link
Copy Markdown
Contributor

@zacharyyankiver zacharyyankiver commented May 1, 2026

Summary

  • Deliver this BRD
  • refine the GA4 advanced configuration UI based on follow-up feedback
  • simplify advanced pattern building around entry fields and wildcard guidance
  • preserve layout consistency and validation behavior while keeping local-only lambda config out of git

Validation

  • npm run test:ci -- src/components/config-screen/assign-content-type/AssignContentTypeRow.spec.tsx src/components/config-screen/assign-content-type/AssignContentTypeSection.spec.tsx src/components/config-screen/assign-content-type/ContentTypeWarning.spec.tsx src/components/config-screen/assign-content-type/AssignContentTypeCard.spec.tsx src/helpers/contentTypeRules/contentTypeRules.spec.ts src/utils/getReportSlug.spec.ts
  • local validation on http://localhost:3000

zacharyyankiver and others added 8 commits April 29, 2026 14:13
- Added advanced path pattern support for building GA4 page paths from selected entry fields.

- Added integer fields as valid substitutions in advanced path patterns, while keeping the standard Slug field dropdown limited to short text fields.

- Added {locale} support, including sidebar locale selection when a configured pattern uses {locale}.

- Updated sidebar locale behavior to default from editor, active, or default locale and display locale options alphabetically.

- Changed wildcard syntax from .* to *, with helper copy explaining wildcard path matching.

- Removed literal vs regex matching in favor of simpler wildcard guidance.

- Added validation that selected entry fields must appear as substitution tags in the pattern.

- Removed unknown-variable validation so literal brace URL segments are allowed.

- Cleaned up config screen copy across intro, advanced matching, field selection labels, trailing slash copy, Slug field tooltip, and Advanced tooltip.

- Cleaned up sidebar UX by improving error messaging, removing Undetermined metric, adjusting the custom date modal, and removing redundant custom date display text.
@lambardi Ben Golden (lambardi) changed the title Refine GA4 advanced matching follow-up UX Refine GA4 advanced matching follow-up UX [] May 2, 2026
@zacharyyankiver
Copy link
Copy Markdown
Contributor Author

Ben confirmed in Slack that the current unknown-variable validation is intentional: arbitrary {...} brace segments should be rejected so the app can keep meaningful validation around selected substitution fields. I validated /docs/{literal}/{slug}/ and confirmed the config correctly shows an unknown variable error for {literal}. The commit message note about allowing literal brace URL segments is outdated, but the implementation behavior is expected.

@mgoudy91 Mitch Goudy (mgoudy91) marked this pull request as ready for review May 4, 2026 16:29
@mgoudy91 Mitch Goudy (mgoudy91) requested review from a team as code owners May 4, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants