Add Contentful app components [MAPS-235]#10614
Open
Joaquin (joaquincasal) wants to merge 46 commits intomasterfrom
Open
Add Contentful app components [MAPS-235]#10614Joaquin (joaquincasal) wants to merge 46 commits intomasterfrom
Joaquin (joaquincasal) wants to merge 46 commits intomasterfrom
Conversation
generateEntries and generateEntriesWithScheduleActions scripts and tests Add deleteContentType function and update deleteEntries script for content type management Remove console log for entry count in deleteEntries script Add deleteEntries script and utility functions for managing Contentful entries
* Setup npm workspaces * Remove preinstall script
This reverts commit 6d1a8d1.
This reverts commit 27bd9c1.
This reverts commit ea17d81.
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduces a shared package
contentful-app-components. It contains reusable code usable by the apps.This is the first version of the package, including just a few components that are already being heavily used in existing apps.
Splitter,ContentTypeMultiSelectuseContentTypes,useInstallationParametersThe package includes a README with examples.
Approach
It's a shared source-only package. Apps import the package by name; they are resolved to the package path, and all dependencies are provided by each app's own
node_modules.We've adopted the package in three existing apps (Hubspot, Braze and Homebase) as a test and verification.
Testing steps
There's a separate
contentful-app-components-testsproject that includes the tests for the components.Breaking Changes
N/A
Dependencies and/or References
More information and specific versions in the README.
Deployment
Since the package is consumed as source (no prebuild), there are no changes to the build or deploy process.