feat: Add a new factory method to Reader which returns std::nullopt if no manifest is found (CAI-9682)#192
Merged
scouten-adobe merged 2 commits intomainfrom Mar 27, 2026
Merged
Conversation
…t` if no manifest is found (CAI-9682)
Contributor
Author
|
Similar to contentauth/c2pa-python#214. |
tmathern
reviewed
Mar 26, 2026
| /// @return A Reader if JUMBF (c2pa/manifest) data is present; std::nullopt if none. | ||
| /// @throws C2paException for errors other than a missing manifest (e.g. invalid asset). | ||
| /// @throws std::system_error if the file cannot be opened. | ||
| static std::optional<Reader> from_asset(IContextProvider& context, const std::filesystem::path &source_path); |
Collaborator
There was a problem hiding this comment.
I assume we don't support context-less Reader because it's deprecated?
Contributor
Author
There was a problem hiding this comment.
Yes, I almost added it and then realized it probably wasn't brilliant to add a new API that was flagged as deprecated.
tmathern
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.